-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Getting rid of drupal console for composer 2 compatibility #40
Conversation
I get the feeling, @dannylamb, that Travis shouldn't be red... |
Every step of the way, y'know? |
I've been getting queued by Travis a lot lately so this may take some time. But I think I've fixed the current issue with Travis. |
...and so the scaffolding does rely on drupal console apparantly? Hard to tell from the output. If I can't pull a rabbit out of my hat we may have to consider finally moving to |
96d30b0
to
85978ff
Compare
Whelp, the |
I think I've finally got this going @seth-shaw-unlv |
Getting the kids lunch right now, but I'll glance at it when I get back to my desk. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
GitHub Issue: Needed for Islandora/islandora#806
What does this Pull Request do?
Pull drupal console from our composer.json since it's not a hard dependency and fails with composer 2.
How should this be tested?
It's already tested b/c Travis is happy with Islandora/islandora#806
Additional Notes:
After this is merged, I'll update Islandora/islandora#806 to pull from 8.x-1.x. Hopefully this unlocks the rest of the repos for Travis.
Interested parties
@Islandora/8-x-committers