Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting rid of drupal console for composer 2 compatibility #40

Merged
merged 7 commits into from
Nov 6, 2020

Conversation

dannylamb
Copy link

GitHub Issue: Needed for Islandora/islandora#806

What does this Pull Request do?

Pull drupal console from our composer.json since it's not a hard dependency and fails with composer 2.

How should this be tested?

It's already tested b/c Travis is happy with Islandora/islandora#806

Additional Notes:

After this is merged, I'll update Islandora/islandora#806 to pull from 8.x-1.x. Hopefully this unlocks the rest of the repos for Travis.

Interested parties

@Islandora/8-x-committers

@seth-shaw-unlv
Copy link

I get the feeling, @dannylamb, that Travis shouldn't be red...

@dannylamb
Copy link
Author

Every step of the way, y'know?

@dannylamb
Copy link
Author

I've been getting queued by Travis a lot lately so this may take some time. But I think I've fixed the current issue with Travis.

@dannylamb
Copy link
Author

...and so the scaffolding does rely on drupal console apparantly? Hard to tell from the output. If I can't pull a rabbit out of my hat we may have to consider finally moving to drupal/recommended-project instead.

@dannylamb
Copy link
Author

dannylamb commented Nov 6, 2020

Whelp, the snapshot builds fail. The internet tells me to update composer based on the error message I'm receiving. But by definition, snapshot means newest, so... I put those build as allowed failures and am moving on. Testing with bleeding edge composer doesn't seem like a required pass to me.

@dannylamb
Copy link
Author

I think I've finally got this going @seth-shaw-unlv

@seth-shaw-unlv
Copy link

Getting the kids lunch right now, but I'll glance at it when I get back to my desk.

Copy link

@seth-shaw-unlv seth-shaw-unlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@seth-shaw-unlv seth-shaw-unlv merged commit b1b6db2 into 8.x-1.x Nov 6, 2020
@seth-shaw-unlv seth-shaw-unlv deleted the no-drupal-console branch November 6, 2020 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants