Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include conformer cross-sections in TSV download #237

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

danielhollas
Copy link
Member

@danielhollas danielhollas commented Mar 14, 2024

Should solve #236, but the current implementation is limited --- the cross sections of individual conformers will be downloaded only when they are displayed in the bokeh Figure when user clicks on "Show conformers". I will deal with this limitation in a separate PR since it will require a bit of code refactoring.

@danielhollas danielhollas self-assigned this Mar 14, 2024
@danielhollas danielhollas added the Enhancement Improvements to existing functionality label Mar 14, 2024
@danielhollas danielhollas marked this pull request as ready for review March 14, 2024 17:58
@danielhollas danielhollas merged commit 4d35b0b into main Mar 15, 2024
6 checks passed
@danielhollas danielhollas deleted the feat/conformer-spectrum-download branch March 15, 2024 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improvements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant