Feat/hw3 #2

itaispiegel · 2024-01-26T17:02:23Z

The PR is still not ready (draft).

TODO

Add a golangci-lint Github workflow for static analysis.
Add a Github workflow that runs the unit tests.
Wait for Reuven to answer the questions I sent him and fix them accordingly.
Clear out all TODOs.
Run more tests and maybe even try to automate tests.
Probably will be a good idea to add the entries to the log only by skb and not by rule.

.gitignore

module/logs.c

… packets

itaispiegel added 27 commits January 26, 2024 18:56

Implement rules table devices

969bdd1

Start implementing the userspace program

6a8213e

Implement the load_rules command and start implementing tests

80e5ba6

Finish the rule parsing

115dd20

Rule saving and loading now works

af085e9

Add examples and README.md files

dcd0179

Extract a util function for splitting lines

14a2f80

Start implementing netfilter hook

9a3000f

Update interface names in fw.h

8966559

Fix whitespace in rules file

57b7398

Optimize by storing ports in big endian - needs docs

c746f80

Implement network hook

6c21910

Fix examples

962662e

Fix field order marshaling and unmarshaling

9bc2ee3

Implement logs table

23bb74f

Implement the ability to read the logs device

fe4734f

Use the minor numbers in fw.h

b109fa7

Fix broken tests

04242d6

Make all enums and structs in fw.h packed

7cab682

Implement the logs device userspace side - wip

2030748

Define fwtypes package

f330c05

Fix timestamp in logs table

b981936

Fix a bug which causes the module to be unable to unload

a233fba

Fix logs table whitespace

fe0d49c

Implement the device for clearing the log

24800aa

Use an external module for pretty printing the logs table

f7a9ac4

Add go.mod

b043ae3

itaispiegel commented Jan 28, 2024

View reviewed changes

.gitignore Outdated Show resolved Hide resolved

itaispiegel commented Jan 28, 2024

View reviewed changes

module/logs.c Outdated Show resolved Hide resolved

Add a Github workflow for golangci-lint

3d589ed

itaispiegel added 8 commits January 28, 2024 17:26

Handle errors in log.Unmarshal

28ea5ae

Define the reset magic and its size as a macro

54c7276

Handle binary.Read and binary.Write errors in rules

800b251

Define golangci-lint workflow to run only on the relevant paths

a5237e3

Use version file in golangci-lint workflow

ec0b145

Add workflow for running unit tests

c5786fd

Update .gitignore to include all go.mod files

f913f52

Remove irrelevant TODOs

08b8783

itaispiegel force-pushed the feat/hw3 branch from 2629bc8 to 08b8783 Compare January 28, 2024 15:56

itaispiegel added 2 commits February 2, 2024 17:15

Handle special packet types

57bced2

Add a script for sending a XMAS packet

55ff497

itaispiegel force-pushed the feat/hw3 branch from 7f55414 to 55ff497 Compare February 2, 2024 15:16

Optimize the hook by parsing the packet before processing it

40a1976

itaispiegel force-pushed the feat/hw3 branch from 6ef77cc to 40a1976 Compare February 2, 2024 16:17

itaispiegel added 5 commits February 2, 2024 18:36

Add script for sending ICMP from a spoofed address

e6aec27

Create log entries by packet and not by rule

816f4eb

Modify the script for sending TCP packets to be able to send also UDP…

003498d

… packets

Update README.md

21bb816

Add pre-commit hook for validating that we're not committing conflicts

5596418

itaispiegel merged commit 3e537c3 into main Feb 2, 2024
3 checks passed

itaispiegel deleted the feat/hw3 branch March 1, 2024 20:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/hw3 #2

Feat/hw3 #2

itaispiegel commented Jan 26, 2024 •

edited

Loading

Feat/hw3 #2

Feat/hw3 #2

Conversation

itaispiegel commented Jan 26, 2024 • edited Loading

itaispiegel commented Jan 26, 2024 •

edited

Loading