fs: system: optimize reflink #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiop
force-pushed
the
reflink
branch
3 times, most recently
from
adc9a34 to
b7d8a2a
Compare
10000 reflinks now take about 1sec instead of 2.7sec
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #234 +/- ##
==========================================
+ Coverage 64.39% 64.53% +0.13%
==========================================
Files 27 27
Lines 2039 2047 +8
Branches 323 324 +1
==========================================
+ Hits 1313 1321 +8
Misses 666 666
Partials 60 60 ☔ View full report in Codecov by Sentry. |
skshetry
reviewed
Dec 6, 2023
| def _reflink_darwin(src: "AnyFSPath", dst: "AnyFSPath") -> None: | ||
| import ctypes | ||
|
|
||
| clonefile = _clonefile() |
There was a problem hiding this comment.
Can we move argtypes and restype up too?
skshetry
reviewed
Dec 6, 2023
|
|
||
|
|
||
| def _reflink_darwin(src: "AnyFSPath", dst: "AnyFSPath") -> None: | ||
| import ctypes |
skshetry
reviewed
Dec 6, 2023
| @@ -36,7 +37,8 @@ def symlink(source: "AnyFSPath", link_name: "AnyFSPath") -> None: | |||
| os.symlink(source, link_name) | |||
|
|
|||
|
|
|||
| def _reflink_darwin(src: "AnyFSPath", dst: "AnyFSPath") -> None: | |||
| @functools.lru_cache(maxsize=1) | |||
| def _clonefile(): | |||
There was a problem hiding this comment.
Is it worth running a logger.debug? Is that expected?
There was a problem hiding this comment.
I would rather know that we are falling back there, so yeah. This is ran 1 time worst case, so not much reason to remove.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
10000 reflinks now take about 1sec instead of 2.7sec
Related https://github.com/iterative/dql/pull/1007