Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: bench: chmod after reflink on macos #236

Closed
wants to merge 1 commit into from

Conversation

efiop
Copy link
Contributor

@efiop efiop commented Dec 6, 2023

No description provided.

@efiop efiop force-pushed the test-reflink-fixup branch from 3e6bbc2 to ebfd4a0 Compare December 6, 2023 01:52
@codecov-commenter
Copy link

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (5e37397) 64.51% compared to head (ebfd4a0) 63.40%.

Files Patch % Lines
tests/benchmarks/test_fs.py 62.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #236      +/-   ##
==========================================
- Coverage   64.51%   63.40%   -1.12%     
==========================================
  Files          27       27              
  Lines        2046     2052       +6     
  Branches      324      325       +1     
==========================================
- Hits         1320     1301      -19     
- Misses        666      692      +26     
+ Partials       60       59       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@efiop
Copy link
Contributor Author

efiop commented Dec 6, 2023

We should not be doing chmodding in linking at all, but rather a layer above during checkout where we know desired permissions. https://github.com/iterative/dql/pull/1007#issuecomment-1841951977

@efiop efiop closed this Dec 6, 2023
@skshetry
Copy link
Member

skshetry commented Dec 6, 2023

In #237, I have _reflink that does not do any chmod, and it's usually faster than pyreflink.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants