fs: reflink: don't try to reset permissions #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should set desired permissions explicitly in layers above this one. For now just getting rid of this and proper permissions will be set up in the followups in `dvc_data.index.checkout`. Related iterative/dvc-data#274
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #238 +/- ##
==========================================
- Coverage 64.51% 64.36% -0.16%
==========================================
Files 27 27
Lines 2046 2043 -3
Branches 324 324
==========================================
- Hits 1320 1315 -5
- Misses 666 668 +2
Partials 60 60 ☔ View full report in Codecov by Sentry. |
This was referenced Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should set desired permissions explicitly in layers above this one.
For now just getting rid of this and proper permissions will be set up in the followups in
dvc_data.index.checkout.Overall it is pretty hard to imagine when cache would be read-only but reflinks would work.
Also important to note that
copyflow may or may not clone permissions too, so we are not worsening things here much.Related iterative/dvc-data#274
Related https://github.com/iterative/dql/pull/1007#issuecomment-1841951977