Skip to content

Commit

Permalink
Fix hot_restart logs
Browse files Browse the repository at this point in the history
  • Loading branch information
itome committed Jun 3, 2024
1 parent ebd5b10 commit 3223cd5
Show file tree
Hide file tree
Showing 5 changed files with 24 additions and 45 deletions.
1 change: 1 addition & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion crates/daemon/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ serde = { version = "1.0.195", features = ["derive"] }
serde_json = "1.0.111"
tokio = { version = "1.32.0", features = ["full"] }
color-eyre = "0.6.2"
log = "0.4.21"

[dev-dependencies]
clap = { version = "4.5.2", features = ["derive"] }
clap = { version = "4.5.2", features = ["derive"] }
22 changes: 0 additions & 22 deletions src/redux/thunk/hot_reload.rs
Original file line number Diff line number Diff line change
Expand Up @@ -39,27 +39,5 @@ where
log::error!("Failed to hot reload: {}", err);
return;
}

while let Ok(params) = run.receive_app_progress().await {
if params.progress_id == Some("hot.reload".to_string()) && !params.finished {
store
.dispatch(Action::StartHotReload {
session_id: session_id.clone(),
})
.await;
break;
}
}

while let Ok(params) = run.receive_app_progress().await {
if params.progress_id == Some("hot.reload".to_string()) && params.finished {
store
.dispatch(Action::CompleteHotReload {
session_id: session_id.clone(),
})
.await;
break;
}
}
}
}
22 changes: 0 additions & 22 deletions src/redux/thunk/hot_restart.rs
Original file line number Diff line number Diff line change
Expand Up @@ -38,27 +38,5 @@ where
log::error!("Failed to hot restart: {}", err);
return;
}

while let Ok(params) = run.receive_app_progress().await {
if params.progress_id == Some("hot.restart".to_string()) && !params.finished {
store
.dispatch(Action::StartHotRestart {
session_id: session_id.clone(),
})
.await;
break;
}
}

while let Ok(params) = run.receive_app_progress().await {
if params.progress_id == Some("hot.restart".to_string()) && params.finished {
store
.dispatch(Action::CompleteHotRestart {
session_id: session_id.clone(),
})
.await;
break;
}
}
}
}
21 changes: 21 additions & 0 deletions src/redux/thunk/run_new_app.rs
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,27 @@ where
message: progress.message,
})
.await;
if progress.progress_id == Some("hot.restart".to_string()) {
if !progress.finished {
store.dispatch(Action::StartHotRestart{
session_id: id.clone(),
}).await;
} else {
store.dispatch(Action::CompleteHotRestart {
session_id: id.clone(),
}).await;
}
} else if progress.progress_id == Some("hot.reload".to_string()) {
if !progress.finished {
store.dispatch(Action::StartHotReload{
session_id: id.clone(),
}).await;
} else {
store.dispatch(Action::CompleteHotReload {
session_id: id.clone(),
}).await;
}
}
},
Ok(params) = run.receive_app_debug_port() => {
let store = store.clone();
Expand Down

0 comments on commit 3223cd5

Please sign in to comment.