Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

makefile: Add uninstall target + add check arg #5129

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

makefile: Add uninstall target + add check arg #5129

wants to merge 2 commits into from
+46 −21

Conversation

alindt
Copy link

@alindt alindt commented Dec 30, 2024

  • add uninstall target
  • restructure and rename targets and vars

@alindt
update Makefile
affae6f 
- add uninstall target
- restructure and rename targets and vars
@alindt alindt requested a review from a team as a code owner December 30, 2024 22:08
@alindt alindt requested review from SamantazFox and removed request for a team December 30, 2024 22:08
unixfox
unixfox requested changes Dec 31, 2024
View reviewed changes
Makefile
format:
crystal tool format
$(CRYSTAL_BIN) tool format --check
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would prefer to have a separate arg for --check

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Separate arg or a different target altogether maybe?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not very familiar with makefiles but I guess separate arg

@unixfox unixfox changed the title update Makefile Add uninstall target + add check arg Jan 2, 2025
@unixfox unixfox changed the title Add uninstall target + add check arg makefile: Add uninstall target + add check arg Jan 2, 2025
@unixfox unixfox requested a review from syeopite January 3, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unixfox unixfox unixfox requested changes

@SamantazFox SamantazFox Awaiting requested review from SamantazFox SamantazFox is a code owner automatically assigned from iv-org/developers

@syeopite syeopite Awaiting requested review from syeopite

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alindt @unixfox