Use UTC for HDate, fix HTime and HDateTime.toAxon #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garethj2
requested review from
thoughtpalette,
hecsalazarf,
riccardoleder,
gretadj2 and
jaxgzz
gretadj2
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found a few issues with
HDateTime.toAxon()that lead onto a wider discussion using UTC time for constructingHDateandHTime.HDateTime.toAxon(): this now always creates adateTime(...)calling using the correct UTC format.HDatenow uses UTC when constructed from a Date.HTimenow uses UTC for milliseconds. This was missing.