feat(frontmatter): Add an option to index frontmatter wikilinks #1673
+43
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(yes I forcepushed for minor typos 6 times 😂) |
|
Here's an example of the PageProperties component for rendering frontmatter I'll probably make a PR for soon, for which I needed this among other things
|
I was missing this feature and implemented it, not knowing that there was jackyzha0#944 already ¯\_(ツ)_/¯ Looking at it now I think that my impl is a little better, and I'd love to have it upstreamed. Closes jackyzha0#820 and jackyzha0#944
necauqua
force-pushed
the
index-frontmatter-wikilinks
branch
from
cf82870 to
de41860
Compare
|
Just want to add that this is huge for me and I'm grateful that you did this @necauqua 🙏 I added this to my project and have had no issues and it's working exactly like it does in obsidian |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was missing this feature and implemented it, not knowing that there was #944 already ¯\_(ツ)_/¯
Looking at it now I think that my impl is a little better, and I'd love to have it upstreamed.
Ready to get review comments, I know the option name is meh.
Closes #820 and #944
Before
After (with indexFrontmatterWikilinks: true)
With my frontmatter component :)