[WIP] Implement proper payload chunked encoding in HTTP api_v3 #6479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chahatsagarmain <[email protected]>
Signed-off-by: chahatsagarmain <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6479 +/- ##
==========================================
- Coverage 96.23% 96.15% -0.09%
==========================================
Files 368 375 +7
Lines 20978 21433 +455
==========================================
+ Hits 20189 20608 +419
- Misses 604 629 +25
- Partials 185 196 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: chahatsagarmain <[email protected]>
Signed-off-by: chahatsagarmain <[email protected]>
Signed-off-by: chahatsagarmain <[email protected]>
yurishkuro
reviewed
Jan 22, 2025
| n, err := resp.Body.Read(buf) | ||
|
|
||
| if n > 0 { | ||
| fullResponse.Write(buf[:n]) |
There was a problem hiding this comment.
if you concatenate the chunks you will end up with invalid JSON
yurishkuro
reviewed
Jan 23, 2025
| // Set chunked transfer encoding before any writes | ||
| w.Header().Set("Transfer-Encoding", "chunked") | ||
| w.Header().Set("Content-Encoding", "gzip") | ||
| w.Header().Set("Vary", "Accept-Encoding") |
yurishkuro
reviewed
Jan 23, 2025
| } | ||
|
|
||
| // Set chunked transfer encoding before any writes | ||
| w.Header().Set("Transfer-Encoding", "chunked") |
There was a problem hiding this comment.
chunked encoding requires each chunk to be prefixed with its size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test