Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[storage] Remove distinction between primary and archive storage interfaces #6567

Merged
merged 82 commits into from
Jan 25, 2025

Fix Typo

5a06df6
Select commit
Loading
Failed to load commit list.
Merged

[storage] Remove distinction between primary and archive storage interfaces #6567

Fix Typo
5a06df6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jan 18, 2025 in 1s

47.98% (target 95.00%)

View this Pull Request on Codecov

47.98% (target 95.00%)

Details

Codecov Report

Attention: Patch coverage is 69.23077% with 36 lines in your changes missing coverage. Please review.

Project coverage is 47.98%. Comparing base (aa7cf7d) to head (5a06df6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
plugin/storage/factory.go 50.00% 14 Missing and 4 partials ⚠️
plugin/storage/es/factory.go 72.50% 8 Missing and 3 partials ⚠️
cmd/remote-storage/app/server.go 64.70% 6 Missing ⚠️
plugin/storage/cassandra/factory.go 95.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (aa7cf7d) and HEAD (5a06df6). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (aa7cf7d) HEAD (5a06df6)
grpc_v1 1 0
unittests 1 0
Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #6567       +/-   ##
===========================================
- Coverage   96.21%   47.98%   -48.24%     
===========================================
  Files         373      186      -187     
  Lines       21400    11111    -10289     
===========================================
- Hits        20591     5332    -15259     
- Misses        616     5402     +4786     
- Partials      193      377      +184

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov