Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Untangle logger from HandleRootSpan #6585

Closed
wants to merge 1 commit into from

Conversation

ADI-ROXX
Copy link
Contributor

@ADI-ROXX ADI-ROXX commented Jan 21, 2025

Which problem is this PR solving?

Description of the changes

  • Removed logger and its use cases

How was this change tested?

  • make test

Checklist

Signed-off-by: cs-308-2023 <[email protected]>
@ADI-ROXX ADI-ROXX requested a review from a team as a code owner January 21, 2025 19:57
@ADI-ROXX ADI-ROXX requested a review from joe-elliott January 21, 2025 19:57
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.21%. Comparing base (156a59d) to head (bc2c567).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6585   +/-   ##
=======================================
  Coverage   96.21%   96.21%           
=======================================
  Files         375      375           
  Lines       21389    21389           
=======================================
  Hits        20580    20580           
  Misses        616      616           
  Partials      193      193           
Flag Coverage Δ
badger_v1 10.65% <ø> (ø)
badger_v2 2.78% <ø> (ø)
cassandra-4.x-v1-manual 16.61% <ø> (ø)
cassandra-4.x-v2-auto 2.71% <ø> (ø)
cassandra-4.x-v2-manual 2.71% <ø> (ø)
cassandra-5.x-v1-manual 16.61% <ø> (ø)
cassandra-5.x-v2-auto 2.71% <ø> (ø)
cassandra-5.x-v2-manual 2.71% <ø> (ø)
elasticsearch-6.x-v1 20.39% <ø> (ø)
elasticsearch-7.x-v1 20.47% <ø> (ø)
elasticsearch-8.x-v1 20.62% <ø> (-0.01%) ⬇️
elasticsearch-8.x-v2 2.77% <ø> (ø)
grpc_v1 12.17% <ø> (-0.01%) ⬇️
grpc_v2 9.04% <ø> (+<0.01%) ⬆️
kafka-3.x-v1 10.34% <ø> (ø)
kafka-3.x-v2 2.78% <ø> (ø)
memory_v2 2.77% <ø> (-0.01%) ⬇️
opensearch-1.x-v1 20.51% <ø> (-0.01%) ⬇️
opensearch-2.x-v1 20.52% <ø> (ø)
opensearch-2.x-v2 2.77% <ø> (-0.01%) ⬇️
tailsampling-processor 0.51% <ø> (ø)
unittests 95.07% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro
Copy link
Member

This PR includes a binary. I accepted the other PR #6586

@yurishkuro yurishkuro closed this Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Untangle Logger parameter in adaptive/aggregator.go
2 participants