[storage] Add helper to storage extension for retrieving sampling store factory #6689
+102
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6689 +/- ##
==========================================
+ Coverage 95.99% 96.03% +0.04%
==========================================
Files 363 363
Lines 20601 20608 +7
==========================================
+ Hits 19775 19791 +16
+ Misses 630 624 -6
+ Partials 196 193 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
mahadzaryab1
changed the title
yurishkuro
reviewed
Feb 7, 2025
| @@ -83,6 +83,20 @@ func GetTraceStoreFactory(name string, host component.Host) (tracestore.Factory, | |||
| return v1adapter.NewFactory(f), nil | |||
| } | |||
|
|
|||
| func GetSamplingStoreFactory(name string, host component.Host) (storage.SamplingStoreFactory, bool) { | |||
There was a problem hiding this comment.
I would prefer to return error and let the caller log it. Otherwise how would we catch config errors when say remote sampling processor asks for a storage by the wrong name.
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
yurishkuro
reviewed
Feb 8, 2025
Signed-off-by: Mahad Zaryab <[email protected]>
yurishkuro
approved these changes
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
GetStorageFactory#6564Description of the changes
Purgerinterface.How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test