Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Move plugin.Configurable To Internal #6693

Merged
merged 2 commits into from
Feb 8, 2025

Conversation

mahadzaryab1
Copy link
Collaborator

Which problem is this PR solving?

Description of the changes

  • This PR moves Configurable from plugin/ to internal/storage/v1

How was this change tested?

  • CI

Checklist

Signed-off-by: Mahad Zaryab <[email protected]>
@mahadzaryab1 mahadzaryab1 added the changelog:skip Trivial change that does not require an entry in CHANGELOG label Feb 8, 2025
@mahadzaryab1 mahadzaryab1 requested a review from a team as a code owner February 8, 2025 16:00
@dosubot dosubot bot added the area/storage label Feb 8, 2025
Signed-off-by: Mahad Zaryab <[email protected]>
Copy link

codecov bot commented Feb 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.98%. Comparing base (24dfa4f) to head (44a586e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6693   +/-   ##
=======================================
  Coverage   95.98%   95.98%           
=======================================
  Files         363      363           
  Lines       20608    20608           
=======================================
  Hits        19780    19780           
  Misses        632      632           
  Partials      196      196           
Flag Coverage Δ
badger_v1 9.82% <0.00%> (ø)
badger_v2 1.82% <0.00%> (ø)
cassandra-4.x-v1-manual 14.79% <0.00%> (ø)
cassandra-4.x-v2-auto 1.81% <0.00%> (ø)
cassandra-4.x-v2-manual 1.81% <0.00%> (ø)
cassandra-5.x-v1-manual 14.79% <0.00%> (ø)
cassandra-5.x-v2-auto 1.81% <0.00%> (ø)
cassandra-5.x-v2-manual 1.81% <0.00%> (ø)
elasticsearch-6.x-v1 19.12% <0.00%> (ø)
elasticsearch-7.x-v1 19.20% <0.00%> (ø)
elasticsearch-8.x-v1 19.37% <0.00%> (ø)
elasticsearch-8.x-v2 1.82% <0.00%> (ø)
grpc_v1 10.80% <100.00%> (ø)
grpc_v2 7.80% <100.00%> (ø)
kafka-3.x-v1 10.12% <0.00%> (ø)
kafka-3.x-v2 1.82% <0.00%> (ø)
memory_v2 1.82% <0.00%> (ø)
opensearch-1.x-v1 19.25% <0.00%> (ø)
opensearch-2.x-v1 19.25% <0.00%> (ø)
opensearch-2.x-v2 1.82% <0.00%> (ø)
tailsampling-processor 0.48% <0.00%> (ø)
unittests 94.86% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mahadzaryab1 mahadzaryab1 enabled auto-merge (squash) February 8, 2025 16:20
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@mahadzaryab1 mahadzaryab1 merged commit a67cd03 into jaegertracing:main Feb 8, 2025
55 checks passed
@mahadzaryab1 mahadzaryab1 deleted the move-configurable branch February 8, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/storage changelog:skip Trivial change that does not require an entry in CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants