Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[query] Drop support for shared grpc/http query server ports #6695

Merged
merged 4 commits into from
Feb 9, 2025

Merge branch 'main' into drop-same-ports

c198d2d
Select commit
Loading
Failed to load commit list.
Merged

[query] Drop support for shared grpc/http query server ports #6695

Merge branch 'main' into drop-same-ports
c198d2d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 9, 2025 in 0s

95.99% (target 95.00%)

View this Pull Request on Codecov

95.99% (target 95.00%)

Details

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.99%. Comparing base (8def385) to head (c198d2d).

Files with missing lines Patch % Lines
cmd/query/app/server.go 88.88% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6695      +/-   ##
==========================================
- Coverage   96.00%   95.99%   -0.02%     
==========================================
  Files         363      363              
  Lines       20610    20558      -52     
==========================================
- Hits        19787    19735      -52     
  Misses        628      628              
  Partials      195      195              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.