Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Change extension_test.go to use GetTraceStoreFactory instead of GetStorageFactory #6696

Merged

Conversation

mahadzaryab1
Copy link
Collaborator

Which problem is this PR solving?

Description of the changes

  • Removes the final usage of GetStorageFactory from extension_test.go by replacing it with GetTraceStoreFactory

How was this change tested?

  • CI

Checklist

@mahadzaryab1 mahadzaryab1 marked this pull request as ready for review February 9, 2025 18:16
@mahadzaryab1 mahadzaryab1 requested a review from a team as a code owner February 9, 2025 18:16
@dosubot dosubot bot added the area/storage label Feb 9, 2025
@mahadzaryab1
Copy link
Collaborator Author

This PR will be followed up by #6697

Copy link

codecov bot commented Feb 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.02%. Comparing base (3bb01fd) to head (453c6f1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6696      +/-   ##
==========================================
+ Coverage   95.99%   96.02%   +0.02%     
==========================================
  Files         363      363              
  Lines       20568    20568              
==========================================
+ Hits        19745    19750       +5     
+ Misses        628      624       -4     
+ Partials      195      194       -1     
Flag Coverage Δ
badger_v1 9.82% <ø> (ø)
badger_v2 1.82% <0.00%> (ø)
cassandra-4.x-v1-manual 14.79% <ø> (ø)
cassandra-4.x-v2-auto 1.81% <0.00%> (ø)
cassandra-4.x-v2-manual 1.81% <0.00%> (ø)
cassandra-5.x-v1-manual 14.79% <ø> (ø)
cassandra-5.x-v2-auto 1.81% <0.00%> (ø)
cassandra-5.x-v2-manual 1.81% <0.00%> (ø)
elasticsearch-6.x-v1 19.12% <ø> (ø)
elasticsearch-7.x-v1 19.20% <ø> (ø)
elasticsearch-8.x-v1 19.37% <ø> (ø)
elasticsearch-8.x-v2 1.93% <0.00%> (+0.11%) ⬆️
grpc_v1 10.80% <ø> (ø)
grpc_v2 7.80% <0.00%> (ø)
kafka-3.x-v1 10.12% <ø> (ø)
kafka-3.x-v2 1.82% <0.00%> (ø)
memory_v2 1.82% <0.00%> (ø)
opensearch-1.x-v1 19.25% <ø> (ø)
opensearch-2.x-v1 19.25% <ø> (ø)
opensearch-2.x-v2 1.82% <0.00%> (ø)
tailsampling-processor 0.48% <0.00%> (ø)
unittests 94.90% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro merged commit 1ac7d6d into jaegertracing:main Feb 9, 2025
56 of 58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove usages of GetStorageFactory
2 participants