[refactor] Conditionally implement interfaces in v1adapter
#6701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
4 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6701 +/- ##
==========================================
- Coverage 96.02% 96.00% -0.02%
==========================================
Files 363 363
Lines 20568 20592 +24
==========================================
+ Hits 19750 19769 +19
- Misses 624 628 +4
- Partials 194 195 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yurishkuro
reviewed
Feb 9, 2025
yurishkuro
reviewed
Feb 9, 2025
yurishkuro
approved these changes
Feb 9, 2025
Signed-off-by: Mahad Zaryab <[email protected]>
yurishkuro
approved these changes
Feb 9, 2025
mahadzaryab1
added a commit
to mahadzaryab1/jaeger
that referenced
this pull request
Feb 11, 2025
…aegertracing#6701)" This reverts commit 97188f4.
4 tasks
mahadzaryab1
added a commit
to mahadzaryab1/jaeger
that referenced
this pull request
Feb 11, 2025
…aegertracing#6701)" This reverts commit 97188f4. Signed-off-by: Mahad Zaryab <[email protected]>
mahadzaryab1
added a commit
that referenced
this pull request
Feb 11, 2025
## Description of the changes - This PR reverts the changes to #6701 since v1 implements the `Purger` and `SamplingStoreFactory` on `storage.Factory` instead of on `spanstore.Reader`. ## How was this change tested? - CI ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
TraceReaderto conditionally propagate the implementations ofstorage.Purgerandstorage.SamplingStoreFactory. Without this change, the implementation of the aforementioned interfaces get lost when we wrap a v1SpanReader.How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test