Add a demo with Jsonp that can be ran inside an OSGI container #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… integration test related to this Signed-off-by: aserkes <[email protected]>
# Conflicts: # impl/pom.xml
Signed-off-by: aserkes <[email protected]>
lukasj
reviewed
Sep 6, 2021
| @@ -341,6 +341,8 @@ | |||
| <Bundle-Description>Jakarta JSON Processing API ${spec.version}</Bundle-Description> | |||
| <Specification-Vendor>${vendor.name}</Specification-Vendor> | |||
| <Implementation-Build-Id>${buildNumber}</Implementation-Build-Id> | |||
| <Import-Package></Import-Package> | |||
| <Require-Capability>osgi.extender;filter:="(osgi.extender=osgi.serviceloader.processor)", osgi.serviceloader; filter:="(osgi.serviceloader=jakarta.json.spi.JsonProvider)"; cardinality:=multiple</Require-Capability> | |||
There was a problem hiding this comment.
Is that osgi extender required? can we avoid using it?
There was a problem hiding this comment.
I mean follow https://docs.osgi.org/reference/portable-java-contracts.html somehow
lukasj
reviewed
Sep 6, 2021
| @@ -341,6 +341,8 @@ | |||
| <Bundle-Description>Jakarta JSON Processing API ${spec.version}</Bundle-Description> | |||
| <Specification-Vendor>${vendor.name}</Specification-Vendor> | |||
| <Implementation-Build-Id>${buildNumber}</Implementation-Build-Id> | |||
| <Import-Package></Import-Package> | |||
There was a problem hiding this comment.
this should not be empty, nothing (or default *) is usually the best
abimarank
suggested changes
Jan 13, 2022
| try { | ||
| artifactUrl = artifact.toURI().toURL(); | ||
| } catch (MalformedURLException e) { | ||
| e.printStackTrace(); |
There was a problem hiding this comment.
Care to remove e.printStackTrace();?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a demo with Jsonp that can be ran inside an OSGI container and an integration test related to this