Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove standalone JSP TCK sources #1295

Merged
merged 3 commits into from
Jun 13, 2024

Conversation

alwin-joseph
Copy link
Contributor

@alwin-joseph alwin-joseph commented Apr 30, 2024

Describe the change

  • Removing the standalone pages TCK sources from platform TCK project.
  • Add glassfish TCK runner for platform jsp tests
  • 18 tests pass , 10 tests fails

Pending:

  • 10 tests fail due to deployment failures , this seems to be configuration issue with the test runner ; will need to revisit the Create Custom Resource(myUrl) .

From server logs :

Exception while deploying the app [jsp_tagext_resource_taghandler_web] : JNDI lookup failed for the resource: Name: java:module/env/myUrl, Lookup: http://webServerHost:webServerPort, Type: java.net.URL -- Lookup failed for http://webServerHost:webServerPort in SerialContext[myEnv={java.naming.factory.state=com.sun.corba.ee.impl.presentation.rmi.JNDIStateFactoryImpl, java.naming.factory.url.pkgs=com.sun.enterprise.naming}]]]

Additional context

@scottmarlow
Copy link
Contributor

Has https://github.com/jakartaee/pages/tree/master/tck passed any testing with a Pages implementation?

@alwin-joseph
Copy link
Contributor Author

Has https://github.com/jakartaee/pages/tree/master/tck passed any testing with a Pages implementation?

The Glassfish 8.0.0-M2 passed. I will wait for Tomcat to re-verify it (after the TCK was restaged) to move the PR out of draft.

pages Spec PR for ballot : jakartaee/specifications#723.
CCR for Tomcat 11 : jakartaee/pages#265.

@alwin-joseph alwin-joseph marked this pull request as ready for review June 13, 2024 11:20
@markt-asf
Copy link
Contributor

Tomcat verified the re-staged TCK:
jakartaee/pages#271

@scottmarlow scottmarlow merged commit 05c460f into jakartaee:tckrefactor Jun 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants