Fix EJB 2.x Refactor #1305
Merged
Fix EJB 2.x Refactor #1305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supercedes Scott's change under #1304
There was code in the assembly suite that was also being used in the ejb suite. This is a problem because I had modernized the assembly suite to use EJB 3.x, but we explicitly want the ejb suite to remain at the EJB 2.x level. The same classes can't really work for both levels like was inadvertently being tried here.
I removed the dependency from the ejb suite, which involved bringing over 2.x compatible versions of all of the needed classes into the ejb suite.
All of this code has been compiled and built from scratch to the best of my ability, so it should be good to go. You can see that I even found an extraneous compilation problem in sec/mdb/MDBClient that I otherwise wouldn't have touched for this piece of work.
CC @alwin-joseph @anajosep @arjantijms @cesarhernandezgt @dblevins @m0mus @edbratt @gurunrao @jansupol @jgallimore @kazumura @kwsutter @LanceAndersen @bhatpmk @RohitKumarJain @shighbar @gthoman @brideck @OndroMih @dmatej
@starksm64 @scottmarlow