Update GlassFish runner to use downloaded Servlet 6.1.0 TCK. #1314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Configure the pom correctly for: * HTTPS requests (needed updated 1.5 Arquillian connector) * Import certificates * Signature test (set correct properties and actual jar from GF) Note that this fails a couple of tests still, but it passes with a locally build 8.0.0-SNAPSHOT. Signed-off-by: Arjan Tijms <[email protected]>
Signed-off-by: Arjan Tijms <[email protected]>
|
Run on the Eclipse CI with latest 8.0 build from the GlassFish /8.0 branch: https://ci.eclipse.org/jakartaee-tck/job/11/job/standalone-tck/job/jakarta-servlet-tck-glassfish/4/ |
dmatej
approved these changes
May 28, 2024
scottmarlow
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
Configure the pom correctly for:
Note that this fails a couple of tests still, but it passes with a
locally build 8.0.0-SNAPSHOT.
Additional context
Fixes one failing test because of TCK misconfiguration. See jakartaee/servlet#638
CC @alwin-joseph @anajosep @arjantijms @cesarhernandezgt @dblevins @m0mus @edbratt @gurunrao @jansupol @jgallimore @kazumura @kwsutter @LanceAndersen @bhatpmk @RohitKumarJain @shighbar @gthoman @brideck @OndroMih @dmatej
@starksm64 @scottmarlow