JSTL Test Fix(tckrefactor branch) for issues/255 in JDK21 due to space character before AM/PM #1329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pnicolucci
reviewed
Jun 17, 2024
jstl/src/main/java/com/sun/ts/tests/jstl/common/client/AbstractUrlClient.java
Outdated
Show resolved
Hide resolved
pnicolucci
reviewed
Jun 21, 2024
.../sun/ts/tests/jstl/compat/onedotzero/positiveFormatLocalizationContextI18NTestJava20Plus.jsp
Show resolved
Hide resolved
starksm64
approved these changes
Jun 26, 2024
starksm64
pushed a commit
to jakartaredhat/platform-tck-refactor
that referenced
this pull request
Jul 14, 2024
…e character before AM/PM (jakartaee#1329) * JSTL Test fix in JDK21 due to space character before AM/PM * correct copyrights * correct copyrights for new files, as per review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s)
Describe the change
Copied the changes from #1320 to fix the refactored JSTL tests to pass in JDK21
To run the jstl tck and test the fix with Glassfish :
cd $WORKSPACE/jstl; mvn clean install: To install the refactored jstl tckcd $WORKSPACE/glassfish-runner/jstl-tck; mvn clean verify: To run the jstl tck with Glassfish 8.0.0-M5(JDK21)cc @pnicolucci