Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MediaType - Missing JSON Merge Patch type #1141 #1143

Closed
wants to merge 1 commit into from
Closed

MediaType - Missing JSON Merge Patch type #1141 #1143

wants to merge 1 commit into from

Conversation

ribandcoder
Copy link

Fix this:
#1141

chkal
chkal previously approved these changes Feb 12, 2023
View reviewed changes
Copy link
Contributor

@chkal chkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

spericas
spericas previously approved these changes Feb 13, 2023
View reviewed changes
@spericas spericas added this to the 4.0 milestone Mar 25, 2024
jamezp
jamezp previously approved these changes Mar 25, 2024
View reviewed changes
jansupol
jansupol previously approved these changes Mar 25, 2024
View reviewed changes
@jamezp jamezp mentioned this pull request Mar 25, 2024
Merged
@jim-krueger
Copy link
Contributor

Please add APPLICATION_MERGE_PATCH_JSON_TYPE to jaxrs-tck/src/main/resources/ee/jakarta/tck/ws/rs/signaturetest/jakarta.ws.rs.sig_4.0.0

@jamezp
Copy link
Contributor

jamezp commented Mar 25, 2024

Just an FYI this can be done with the following command:

mvn clean package -Precord-signature,EFTL

This generates a file named jakarta.ws.rs.sig_4.0.0-SNAPSHOT in the jaxrs-tck/target directory. From there you need to copy the content over to the jaxrs-tck/src/main/resources/ee/jakarta/tck/ws/rs/signaturetest/jakarta.ws.rs.sig_4.0.0 file.

Note this if #1244 is not merged first, this will also include the removal of the Jakarta XML Binding.

@spericas spericas dismissed stale reviews from jansupol, jamezp, chkal, and themself via c6db282 March 27, 2024 19:50
@spericas spericas mentioned this pull request Mar 27, 2024
Merged
@spericas
Copy link
Contributor

Replaced by PR #1246.

@spericas spericas closed this Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jansupol jansupol jansupol left review comments

@spericas spericas spericas left review comments

@jamezp jamezp jamezp left review comments

@chkal chkal chkal left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
6 participants
@ribandcoder @jim-krueger @jamezp @spericas @chkal @jansupol