Add the enforcer plugin and require a minimum of Java 21 to compile t… #1203
Conversation
jamezp
force-pushed
the
compile-to-java-17
branch
from
faa7561 to
fc42df4
Compare
…his project. For the API, compile down to Java 17. Ensure the TCK is compiled to Java 21. Add a profile for when a src/main/java21 directory is present, the JAR will become a multi-release JAR. Signed-off-by: James R. Perkins <[email protected]>
jamezp
force-pushed
the
compile-to-java-17
branch
2 times, most recently
from
177e9a2 to
1925da9
Compare
…at Java SE 17. The TCK itself should also require Java SE 17 as a minimum. Signed-off-by: James R. Perkins <[email protected]>
jamezp
force-pushed
the
compile-to-java-17
branch
from
1925da9 to
8633c10
Compare
|
Please note I've changed this PR to have the TCK compile to Java SE 17 as well. It was noted in the Jakarta EE spec meeting there was never an intent for specification TCK's to require Java 21. |
|
So we can just set |
Yes, we could do that as well. The only reason for the enforcer plugin is to know early if you're on the right JDK. It's in no way critical. |
| @@ -13,7 +13,7 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| strategy: | |||
| matrix: | |||
| java: [ '21-ea' ] | |||
| java: [ '17', '21' ] | |||
There was a problem hiding this comment.
This is not what we discussed. It simply runs two parallel builds, one using JDK 17 and one using JDK 21. For a MR, we just need a single build on JDK 21 but with two compilation targets, 17 and 21.
There was a problem hiding this comment.
We currently have no reason for a MR JAR. We can consider adding it back, but without the need for a META-INF/versions/21 it makes no sense.
There was a problem hiding this comment.
The MR was the last that you and me agreed upon, but indeed, now that Arjan vetoed against the MR, my comment is obsolete.
|
Here it says:
|
|
Given the proposal of 3.2, I'm going to close this. We can re-address it if plans change. |
The minimum level should remain at Java SE 17. The TCK itself should also require Java SE 17 as a minimum.
resolves #1202