Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1239] Use the correct Variant constructor for the header content lan… #1240

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

jamezp
Copy link
Contributor

@jamezp jamezp commented Mar 19, 2024

…guage TCK test.

resolves #1239

This potentially may need to be back ported to 3.1 as well.

Copy link
Contributor

@spericas spericas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, this looks like a bug.

@spericas
Copy link
Contributor

@alwin-joseph Do you agree?

@alwin-joseph
Copy link
Contributor

@alwin-joseph Do you agree?

Agree.

I think the test was passing with previous changes as java.util.Locale accepted "en-US" also as language at

this.language = (language == null) ? null : new Locale(language);
.

@spericas spericas merged commit 7ad97a8 into jakartaee:main Mar 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants