-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renderers fork #93
base: renderers
Are you sure you want to change the base?
Renderers fork #93
Conversation
…ideo, and img tags, render markdown, moved styling to stub stylesheet
…asses render kwargs to dominate, fixed bugs with lists, added tests
…ges and links, started writing the collection view rendering
Hello, what else needs to be done here to use the native web "Export as HTML" feature? Referred here from #178 Edit: Ideally something like this: https://pypi.org/project/notion-backup |
I think the arturtsmborski fork might have more work. You would need to finish the TODOs above (there's some missing unhandled blocks), write some css for the output html (because I never got as far as styling anything, I think it was originally meant to be optional, so you could have structured html without any styling if you wanted to style it yourself), and test it against all the Notion block types (because there's a lot of corner cases) |
Adds
HTMLRenderer
tonotion-py
, from @jamalex 's original PRI rewrote the original PR with
dominate
. This makes it much easier to add attributes and combine elements while rendering.I also removed all the internal styles. I'd rather we add class names and let the user make their own stylesheet. If absolutely necessary, we could provide a
StyledHTMLRenderer
that outputs a default stylesheet in a<style>
tag along with the HTML or make it a flagI also added unit tests for this with pytest for my own sanity.
Let me know of your thoughts.
TODO:
BaseRenderer