create outbound dial from webhook ws #581
Conversation
lib/session/call-session.js
Outdated
| } | ||
| } | ||
|
|
||
| async _validateCreateCall(opts) { |
There was a problem hiding this comment.
why do we need to validate here? The endpoint we are calling /createCall will do this validation. So it seems duplicated...can't we just capture the error response (typically a 400 Bad Request) and send it back over the websocket in some form?
There was a problem hiding this comment.
I removed the part of code for data validation, I just now keep the code for transforming data that feature server can understand and process the outbound call
|
@xquanluu is this completed ? |
davehorton
force-pushed
the
feat/rest_dail_ws
branch
from
e2d579a to
5195f6c
Compare
|
@xquanluu @vdharashive is this PR tested and ready for merge? |
|
From my site, It's tested and working together with conference example app. |
|
But wait me to clean up the code as you mentioned above |
xquanluu
force-pushed
the
feat/rest_dail_ws
branch
from
029f54a to
e2a9925
Compare
|
Hi @davehorton I have clean up the code and retested on jambonz.me Please help me to review the code one again |
xquanluu
changed the title
* wip, create outbound dial from webhook ws * wip, create outbound dial from webhook ws * clean
No description provided.