Fix/gather timeout #594
Fix/gather timeout #594
Conversation
|
can you open an issue and describe this bug? |
|
Opened issue |
lib/tasks/gather.js
Outdated
| @@ -35,6 +35,7 @@ class TaskGather extends SttTask { | |||
|
|
|||
| /* timeout of zero means no timeout */ | |||
| this.timeout = this.timeout === 0 ? 0 : (this.timeout || 15) * 1000; | |||
| this.interDigitTimeout = (this.interDigitTimeout > 0 ? this.interDigitTimeout : 0) * 1000; | |||
There was a problem hiding this comment.
was this changed needed to fix this bug? Or is it an unrelated fix?
There was a problem hiding this comment.
this is to make sure there is value for interDigitTimeout that later we can do compare this. interDigitTimeout <= 0.
But I think this is not needed.
I added new changes and retested on jambonz.me
There was a problem hiding this comment.
Yes I have a feeling we are over-complicating things here. I will have more time to review later today
There was a problem hiding this comment.
where are we with this PR @xquanluu ?
davehorton
force-pushed
the
fix/gather_timeout
branch
from
95c097b to
879dbc7
Compare
|
I remembered that you gave me some suggestion to solve this problem, I applied and retested on jambonz.me, and it was working at that time. It's good to be merged |
Fix gather cannot be timeout if missing
minDigits#597