Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fortran oo support with unittest #243

Merged
merged 6 commits into from
Jan 7, 2025

Conversation

krystophny
Copy link
Contributor

@krystophny krystophny commented Jan 5, 2025

This is a variant of #239 where I did some modifications on top of the great work of @danbeibei

  1. Change from pytest back to unittest. Dependencies between tests are preserved as comments for later.
  2. Change primary accuracy to real(kind=8) and pre-compute pi. I felt more confident with the "almost equal" asserts that work slightly differently in unittest.
  3. Fix CI build failures for type_check example #242 due to small issues in Makefile.meson in some examples.

@jameskermode if this fits your requirements, it should be ready to merge -- ideally first #239 and than this one here.

@jameskermode
Copy link
Owner

Great, thanks, I'm happy to merge this - will do as you say and merge #239 first. Do you happen to know why the x86_64 wheel builds are getting cancelled?

@jameskermode
Copy link
Owner

Looks like this now needs some conflicts resolving before it can be merged. Will try to get to this later.

@krystophny
Copy link
Contributor Author

Resolved the conflicts, no idea why this happened because the branch was based on #239 but looks fine for now.

@krystophny
Copy link
Contributor Author

krystophny commented Jan 6, 2025

... about the macos x86_64 builds, I don't know, but it happend to me in all CI/CD jobs up to now. I checked in the action log and it says

The macOS-12 environment is deprecated, consider switching to macOS-13, macOS-14 (macos-latest) or macOS-15. For more details, see actions/runner-images#10721
GitHub Actions has encountered an internal error when running your job.

@krystophny
Copy link
Contributor Author

... looks fine when hardcoding macos-13 instead of macos-latest on x86_64. macos-latest is not anymore supported there, see actions/runner-images#9741

@jameskermode
Copy link
Owner

Thanks for fixing that! I'll go ahead and merge this and the follow up PRs and then see where we are. Once all building correctly I'll do a new release.

@jameskermode jameskermode merged commit 69b61af into jameskermode:master Jan 7, 2025
23 checks passed
@danbeibei
Copy link

Great, thanks @krystophny for doing the rebase work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI build failures for type_check example
3 participants