Clarify use of capital letters #1083
Merged
+23
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pljones
reviewed
Jan 6, 2025
pljones
reviewed
Jan 9, 2025
pljones
reviewed
Jan 11, 2025
pljones
approved these changes
Jan 11, 2025
mcfnord
reviewed
Jan 12, 2025
contribute/en/Style-and-Tone.md
Outdated
| @@ -67,9 +67,9 @@ Try not to sound like a robot. Write conversationally, as if you were talking to | |||
|
|
|||
| Headings use sentence case “This is a heading” unless delineated (eg “Look - This is a heading”). | |||
|
|
|||
| Nouns use lower case unless they have a formal definition in this style guide (eg “Directory”, “Fader”). The only exception to this is the word “person” or “people” which can remain in lower case. | |||
| Nouns use lower case unless they have a formal definition in this style guide (eg “Directory”, “Fader”) or refer to specific Jamulus features (eg "Audio Alerts", "Jitter Buffer"). The only exception to this is the word “person” or “people” which can remain in lower case. | |||
There was a problem hiding this comment.
Suggested change
| Nouns use lower case unless they have a formal definition in this style guide (eg “Directory”, “Fader”) or refer to specific Jamulus features (eg "Audio Alerts", "Jitter Buffer"). The only exception to this is the word “person” or “people” which can remain in lower case. | |
| Nouns use lower case unless they have a formal definition in this style guide (e.g. “Directory”, “Fader”) or refer to specific Jamulus features (e.g. “Audio Alerts”, “Jitter Buffer”). The only exception to this is the word “person” or “people” which can remain in lower case. |
mcfnord
reviewed
Jan 12, 2025
contribute/en/Style-and-Tone.md
Outdated
|
|
||
| Refer to UI labels in inverted commas (eg 'click on the “mute” button') | ||
| Refer to UI labels in inverted commas (eg 'click on the “Mute” button') |
There was a problem hiding this comment.
Suggested change
| Refer to UI labels in inverted commas (eg 'click on the “Mute” button') | |
| Refer to UI labels in inverted commas (e.g. 'click on the “Mute” button'). |
As per @mcfnord suggestion on earlier PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just for the style guide, but I've created a PR just in case a direct commit to main causes a problem.