Simplify Architectures and add thin wrapper for arbitrary modules #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the architecture and is tested elsewhere
use hidden attributes (with an _) in the attrs classes so we can have abstract properties and allow architectures to take them as input redefine dims on architectures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplified Architectures by turning the
ArchitectureConfig+Architecturecombo into justArchitectureConfigwith a.modulemethod that returns the plain torch module.Everything we need on top of the
torch.nn.moduleis provided by theArchitectureConfig. I.e.input_shape,num_in_channels,num_out_channelsetc.If someone else wants to use the model its as simple as just calling
.moduleto get a pure torch module.Adds support for a
WrappedArchitectureConfigthat takes as one of its arguments atorch.nn.Module. Note that we cannot support serializing this config to file or database since it contains a fulltorch.nn.Moduleinstance.