fix(hubs): fix shared link text (box#3657)

fix public shared link text for hubs
jankowiakdawid · Sep 16, 2024 · a938524 · a938524
1 parent 3480efb
commit a938524
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 18 deletions.
diff --git a/i18n/en-US.properties b/i18n/en-US.properties
@@ -1838,8 +1838,6 @@ boxui.unifiedShare.peopleInThisFolder = Invited people only
 boxui.unifiedShare.peopleInYourCompany = People in your company
 # Description of an open shared link
 boxui.unifiedShare.peopleWithLinkDescription = Publicly accessible and no sign-in required
-# Description of an open shared link with signed required
-boxui.unifiedShare.peopleWithLinkSignedInRequiredDescription = Publicly accessible, sign-in required
 # Text to show that those having the link will have access
 boxui.unifiedShare.peopleWithTheLinkText = People with the link
 # Text used in button label to describe permission level - previewer

diff --git a/src/features/unified-share-modal/SharedLinkAccessDescription.js b/src/features/unified-share-modal/SharedLinkAccessDescription.js
@@ -17,14 +17,6 @@ type Props = {
 };
 
 const SharedLinkAccessDescription = ({ accessLevel, enterpriseName, itemType }: Props) => {
-    const getDescriptionForAnyoneWithLink = (type: ItemType) => {
-        switch (type) {
-            case ITEM_TYPE_HUBS:
-                return messages.peopleWithLinkSignedInRequiredDescription;
-            default:
-                return messages.peopleWithLinkDescription;
-        }
-    };
     const getDescriptionForAnyoneInCompany = (type: ItemType) => {
         switch (type) {
             case ITEM_TYPE_FOLDER:
@@ -57,7 +49,7 @@ const SharedLinkAccessDescription = ({ accessLevel, enterpriseName, itemType }:
 
     switch (accessLevel) {
         case ANYONE_WITH_LINK:
-            description = getDescriptionForAnyoneWithLink(itemType);
+            description = messages.peopleWithLinkDescription;
             break;
         case ANYONE_IN_COMPANY:
             description = getDescriptionForAnyoneInCompany(itemType);

diff --git a/...ures/unified-share-modal/__tests__/__snapshots__/SharedLinkAccessDescription.test.js.snap b/...ures/unified-share-modal/__tests__/__snapshots__/SharedLinkAccessDescription.test.js.snap
@@ -181,8 +181,8 @@ exports[`features/unified-share-modal/SharedLinkAccessDescription people with li
   className="usm-menu-description"
 >
   <FormattedMessage
-    defaultMessage="Publicly accessible, sign-in required"
-    id="boxui.unifiedShare.peopleWithLinkSignedInRequiredDescription"
+    defaultMessage="Publicly accessible and no sign-in required"
+    id="boxui.unifiedShare.peopleWithLinkDescription"
     values={
       {
         "company": "Box",

diff --git a/src/features/unified-share-modal/messages.js b/src/features/unified-share-modal/messages.js
@@ -291,11 +291,6 @@ const messages = defineMessages({
         description: 'Description of an open shared link',
         id: 'boxui.unifiedShare.peopleWithLinkDescription',
     },
-    peopleWithLinkSignedInRequiredDescription: {
-        defaultMessage: 'Publicly accessible, sign-in required',
-        description: 'Description of an open shared link with signed required',
-        id: 'boxui.unifiedShare.peopleWithLinkSignedInRequiredDescription',
-    },
     peopleInSpecifiedCompanyCanAccessFolder: {
         defaultMessage: 'Anyone at {company} with the link or people invited to this folder can access',
         description: 'Description of a specific company shared link for a folder. {company} is the company name',