Clear serial error flags after reading them #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementaion does not clear the error bits in the ISR register when running
Rx.read()
. This means that after an error has occured, all future reads will return the same error. The bits can be reset by writing to theICR
register which is what this patch does.I'm a bit sceptical of the
unsafe
blocks, but they seem required as theRx
struct only contains a pointer to the USARTx registers.I can also see this being implemented as a separate
clear
function which resets all error flags independently ofread
but I believe that would require modifying theembedded-hal
crate, right?