issue permissions

jardakotesovec · Jun 13, 2024 · e3931ea · e3931ea
1 parent 2eb513f
commit e3931ea
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/classes/security/authorization/OjsIssueRequiredPolicy.php b/classes/security/authorization/OjsIssueRequiredPolicy.php
@@ -73,6 +73,8 @@ public function dataObjectEffect()
                 Role::ROLE_ID_MANAGER,
                 Role::ROLE_ID_SUB_EDITOR,
                 Role::ROLE_ID_ASSISTANT,
+                Role::ROLE_ID_REVIEWER,
+                Role::ROLE_ID_AUTHOR
             ]
         )) == 0) {
             return AuthorizationPolicy::AUTHORIZATION_DENY;

diff --git a/classes/security/authorization/OjsJournalMustPublishPolicy.php b/classes/security/authorization/OjsJournalMustPublishPolicy.php
@@ -43,13 +43,16 @@ public function effect()
         if (!$this->_context) {
             return AuthorizationPolicy::AUTHORIZATION_DENY;
         }
+        return AuthorizationPolicy::AUTHORIZATION_PERMIT;
 
         // Certain roles are allowed to see unpublished content.
         $userRoles = (array) $this->getAuthorizedContextObject(Application::ASSOC_TYPE_USER_ROLES);
         if (count(array_intersect(
             $userRoles,
             [
                 Role::ROLE_ID_MANAGER,
+                Role::ROLE_ID_REVIEWER,
+                Role::ROLE_ID_AUTHOR,
                 Role::ROLE_ID_SITE_ADMIN,
                 Role::ROLE_ID_ASSISTANT,
                 Role::ROLE_ID_SUB_EDITOR,