Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: should early return #131

Merged
merged 1 commit into from
Jul 5, 2023
Merged

fix: should early return #131

merged 1 commit into from
Jul 5, 2023

Conversation

jason89521
Copy link
Owner

@jason89521 jason89521 commented Jul 5, 2023

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Testing
  • Refactor
  • Chore (tool changes, configuration changes, and changes to things that do not actually go into production at all)

Implementation

Related Issue

#16

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #131 (e688b06) into main (6f8a7bc) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #131   +/-   ##
=======================================
  Coverage   97.74%   97.74%           
=======================================
  Files          28       28           
  Lines        1551     1551           
  Branches      239      240    +1     
=======================================
  Hits         1516     1516           
  Misses         35       35           
Impacted Files Coverage Δ
src/lib/model/Model.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jason89521 jason89521 merged commit 1bd6867 into main Jul 5, 2023
@jason89521 jason89521 deleted the fix/early-return branch July 5, 2023 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant