bugfix: fix to cell value vertical-align in tables #5793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think I would prefer it to specify what we want there. Cause maybe whatever we inherit changes later? |
|
Ok, I am on a weird arch linux setup here and cannot make screenshots but exponents are still not aligned with other numbers... |
|
Ah @FBartos gave me the great idea to do as the young people do: |
|
Maybe bottom alignment is better? |
|
Well, this is actually due to the fact that the cell elements with exponent and the numeric elements without indices are not the same height, a height difference of 1-2 pixels by auto adjusted. |
|
I also adjusted latex img vertical align in tables, test case in jaspTestModule-> test jaspHtml. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: https://github.com/jasp-stats/INTERNAL-jasp/issues/2794
Not sure why we set to 'top', the browser user agent stylesheet auto set to middle/inherit by default so we just remove it.
Or we can specify it to be fixed to center alignment, any preference?
Note: Maybe the unit test .jasp files also need to be updated because the CSS style string will be changed.