Mixed Models fixes #30
Conversation
by reducing the scaling rate
I can't believe that I figured this QML thingy on my own :)
|
I can't install this as a developer module and test :(
|
|
hmm, I'm not getting the jaspGraphs error when using the last nightly |
|
Perhaps someone else should attempt to review this, since I'm unable to get this to run on my mac. |
|
@FBartos whenever you're ready just re-request a review! |
There was a problem hiding this comment.
Ufff, so I went through the linked issues, it seems that they are now fixed.
I went through the code relatively fast, so I did not check every line of code. But it seems generally ok now, including the style changes.
I have one small remark about renaming option values, when you figure that out I think this is ok to be merged.
Co-authored-by: Simon Kucharsky <[email protected]>
Thanks, these are all fair points. To be honest, I did not know how to test it. |
|
I tried to propagate the changes to the rest of the update, but the module just fails to be installed in JASP. Any idea why? |
|
It just crashes JASP hard |
There was a problem hiding this comment.
I did not know how to test it.
Yeah that's understandable. Basically, you need to create a .jasp file with a 0.14.1 JASP version and then load it up after installing your new version of the module. If the options that you changed show something like this
Then the upgrade is not working.
but the module just fails to be installed in JASP. Any idea why?
No idea, it works for me now just fine... Maybe try Preferences -> Advanced -> Clean installed modules and packages, restart JASP and try install the module again. If that does not work, then I guess it's something for @JorisGoosen to look into.
Otherwise it looks good, I left one minor comment. I guess once we are sure the module is installing correctly, I am fine with merging it.
Co-authored-by: Simon Kucharsky <[email protected]>
|
I propagated the changes to the rest, tried removing the installed modules and packages but it didn't help:
|
It still does work for me, the upgrades are now also working properly. It could be a bug in a nightly, or something OS specific...? @JorisGoosen @vandenman any ideas? If this is resolved, I think it's good to be merged. |
I've been looking into it, some other people also had issues. But for them it seems resolved now. Maybe also for @FBartos? |
|
Yes, it actually installed properly on the latest development nightly (I'm not touching that weird Czech stuff :D ) |
There was a problem hiding this comment.
Unless @vandenman or @AlexanderLyNL object, I am willing to merge this monster.
|
Unfortunately, I'm still unable to install and test this as a development module, not even with the latest nightly jasp-stats/jasp-desktop@a4e5065 |
https://github.com/jasp-stats/jasp-test-release/issues/1358 then? |
|
A nightly which includes the translation fixes Frantisek just made, just for you @AlexanderLyNL |
|
Can you still install it as a development module? I wanted to fix: https://github.com/jasp-stats/jasp-test-release/issues/1209#issuecomment-895555271 but can't install it even without any additional changes (and I tried 3 different nightlies) |
|
I still can't install a development module with the new nightly and used Joris's special build to test. |
|
Should we maybemerge this and leave additional fixes for later? This has been going on for long enough now I think. It just gets bigger and bigger |
|
sure, let's merge this. |
fixes: jasp-stats/jasp-test-release#1208
fixes: jasp-stats/jasp-test-release#1207
fixes: jasp-stats/jasp-test-release#1210
fixes: jasp-stats/jasp-test-release#1260
fixes: jasp-stats/jasp-test-release#1326
fixes: jasp-stats/jasp-test-release#1327
fixes: jasp-stats/jasp-test-release#1331
fixes: jasp-stats/jasp-test-release#1331
fixes: jasp-stats/jasp-test-release#1330
fixes: jasp-stats/jasp-test-release#1323
should fix: jasp-stats/jasp-test-release#1329 (the fix works when run from R interactively - the analysis produces the correct error, but it still fails as a development module, can't figure out why though :( )