Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major update for capability analysis #296

Merged
merged 45 commits into from
Apr 2, 2024

Conversation

JTPetter
Copy link
Contributor

@JTPetter JTPetter commented Jan 4, 2024

  • Created better GUI to select grouping by variable or manual in PCA and related functionality.
  • Created GUI to select how to handle unequal subgroup sizes in PCA
  • Created GUI to use stages variable in PCA.
  • Implemented missing value handling for probability plot and table in process capability study.
  • Implemented functionality to handle unequal subgroup sizes for control charts in process capability study.
  • Implement functionality to handle missing measurement values in normal process capability tables.
  • Implement functionality to handle missing measurement values in non-normal process capability tables.
  • Implement functionality to handle missing values in subgroups in process capability study.
  • Added option to set specification limits as physical boundaries.
  • Changed selection of control charts in PCA to dropdown to improve dynamic selection based on other properties.
  • Added advanced option to use different methods for estimating std. dev. in PCA.
  • Fixed all capitalization and spelling.
  • Added name of distribution to title of probability distribution.
  • Renamed "Axis labels" to "Timestamp (optional)" in all analyses.
  • Add options to display/hide distributions and specification limits in PCA plot, and add legend plus annotation.
  • Display "*" instead of NA everywhere in PCA when necessary specification limits are not set.
  • Added stages functionality for everything in PCA.
  • Added option to select direction of bin boundary (right/left open) for histograms in PCA.
  • Fixes [Feature Request - Quality Control] Add specification limits to x-mR chart in process capability study jasp-issues#2443 (Added option to display specification limits in x-mR Chart)
  • Slightly moved labels of control limits to reduce whitespace (adjusted many unit tests).
  • Added legend to distribution histogram in PCA.
  • Fixes https://github.com/jasp-stats/jasp-test-release/issues/2508
  • Making PCA more robust to many edge cases.
  • Added extensive unit tests, verified with Minitab.
  • Updated help file.
  • Remove most ggplot2 warnings.

@JTPetter JTPetter changed the title Rewriting capability analysis Major update for capability analysis Jan 4, 2024
@JTPetter
Copy link
Contributor Author

JTPetter commented Jan 4, 2024

Most of the added lines are related to the extensive unit tests, so not quite as much to review as it might look like at first glance!

@JTPetter
Copy link
Contributor Author

@koenderks @vandenman Do you think you might be able to take a look sometime soon?

@JTPetter
Copy link
Contributor Author

Definitely want to include this and #297 in 0.19, ideally send out a nightly already to some people beforehand

Copy link
Contributor

@koenderks koenderks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did found one error, it error'ed for all the non-normal distributions in this case. Requires only unzip
error.jasp.zip

@JTPetter
Copy link
Contributor Author

JTPetter commented Apr 2, 2024

@koenderks Thank you, with #297 this already gives a more informative error.

@JTPetter JTPetter merged commit cbb999f into jasp-stats:master Apr 2, 2024
5 checks passed
@JTPetter JTPetter deleted the rewritingCapabilityAnalysis branch April 4, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request - Quality Control] Add specification limits to x-mR chart in process capability study
2 participants