-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement data preloading #361
Conversation
added a workaround to harmonize the column encoding for the names in 'modelTerms'
changed the example data used for the kendall's tau tests in bayesian correlation because bstat kept crashing due to the very small effect size in the old example data (at least, that's my hypothesis)
@JorisGoosen, I added you as a reviewer so you could see what I did about the encoding issue we discussed on Tuesday. Specifying the allowed types in the QML and setting |
@vandenman, I haven't been able to get Johnny's attention (via Mattermost or email). Are you still willing to review this PR? |
inst/qml/RegressionLinear.qml
Outdated
@@ -63,7 +63,8 @@ Form | |||
availableVariablesList.source: ['covariates', 'factors'] | |||
startIndex: 0 | |||
availableVariablesListName: "availableTerms" | |||
allowedColumns: [] | |||
allowedColumns: ['scale', 'nominal'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you add these specifications? The column type specification already happens in the main menu, where the user specifies either continuous (covariates) or factors (categorical) predictors, and those types are then respected in the model box. Allowing the type to change seems a bit weird, also since it does not get changed in all models and therefore causing non-nested model comparisons.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is a vestige of an attempt to fix the variable name encoding problems that I ended up working around with the routines defined in "R/commonClassicalRegression.R". That attempt didn't work, but I forgot to undo this change.
@kylelang great changes! just two things:
![]() |
forcing conversion to scale for DV in poisson regression
14bd402
to
1245505
Compare
The crash in Poisson regression was caused by the error-checking routines trying to analyze the factor DV as a numeric variable. Since the data preloading types the variables before they get to R, a nominal or ordinal DV gets to R as a factor. Since we always want the DV in Poisson regression to be an integer (I think), it seems cleanest to force the appropriate type conversion in the QML form. That's what I've implemented in my latest commit. We could also do the type conversion in R, but it feels simpler and more transparent to do the conversion where the user can see what's happening. |
@JohnnyDoorn, this PR is ready for re-review. |
This PR makes three meaningful and two trivial adjustments.
Meaningful
options$modelTerms
.modelTerms
element may be processed too early (i.e., before the column names indataset
are properly encoded), but that's pure speculation.dataset
by decoding both themodelTerms
names and column names indataset
back to the user-supplied versions and mapping from there.Trivial
.computeCorBayes()
to only calculate the stats requested by the user.