Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor frontmatter location parsing to util function #461

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

charles-toller
Copy link

Pull Request Description

Fixes issues with frontmatter location parsing, and refactors it to a central function.

Changes Proposed

Refactors the frontmatter location parsing to a util function, and enables the usage of strings in that field, e.x.:

  • other text [<lat>,<long>]
  • <lat>,<long>
  • <percent>%,<percent>%

Related Issues

Fixes #431

Checklist

  • I have read the contribution guidelines and code of conduct.
  • I have tested the changes locally and they are working as expected.
  • I have added appropriate comments and documentation for the code changes.
  • My code follows the coding style and standards of this project.
  • I have rebased my branch on the latest main (or master) branch.
  • All tests (if applicable) have passed successfully.
  • I have run linters and fixed any issues.
    • This project doesn't seem to have a linter of choice
  • I have checked for any potential security issues or vulnerabilities.

Screenshots (if applicable)

Additional Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞 Location in frontmatter cannot be parsed unless manually changed in an external program
1 participant