wip: baseline trigger added on pr to get the first baselines

jaxleyverse · Nov 21, 2024 · a20bbd2 · a20bbd2
1 parent 61c577c
commit a20bbd2
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 23 deletions.
diff --git a/.github/workflows/regression_tests.yml b/.github/workflows/regression_tests.yml
@@ -30,11 +30,11 @@ jobs:
     - name: Run benchmarks and compare to baseline
       if: github.event.pull_request.base.ref == 'main'
       run: |
-        # Check if regression test results exist in main branch
-        if [ -f 'git cat-file -e main:tests/regression_test_baselines.json' ]; then
-          git checkout main tests/regression_test_baselines.json
-        else
-          echo "No regression test results found in main branch"
-        fi
+        # # Check if regression test results exist in main branch
+        # if [ -f 'git cat-file -e main:tests/regression_test_baselines.json' ]; then
+        #   git checkout main tests/regression_test_baselines.json
+        # else
+        #   echo "No regression test results found in main branch"
+        # fi
         pytest -m regression
-        git checkout
+        # git checkout
diff --git a/.github/workflows/update_regression_baseline.yml b/.github/workflows/update_regression_baseline.yml
@@ -1,23 +1,31 @@
-# .github/workflows/regression_tests.yml
+# .github/workflows/update_regression_tests.yml
 name: Update Regression Baseline
 
 on:
-  issue_comment:
-    types: [created]
-
+  # issue_comment:
+  #   types: [created]
+  pull_request:
+    branches:
+      - main
 
 jobs:
-  regression_tests:
+  update_regression_tests:
     name: regression_tests
-    if: github.event.issue.pull_request && contains(github.event.comment.body, '/update_baseline')
+    # if: github.event.issue.pull_request && contains(github.event.comment.body, '/update_baseline')
     runs-on: ubuntu-20.04
     permissions:
       contents: write
       pull-requests: write
 
     steps:
-    - uses: actions/checkout@v3
+    - name: Get PR branch
+      uses: xt0rted/pull-request-comment-branch@v1
+      id: comment-branch
+
+    - name: Checkout PR branch
+      uses: actions/checkout@v3
       with:
+        ref: ${{ steps.comment-branch.outputs.head_ref }}
         lfs: true
         fetch-depth: 0 # This ensures we can checkout main branch too
 
@@ -30,15 +38,6 @@ jobs:
       run: |
         python -m pip install --upgrade pip
         pip install -e ".[dev]"
-
-    - name: Get PR branch
-      uses: xt0rted/pull-request-comment-branch@v1
-      id: comment-branch
-
-    - name: Checkout PR branch
-      uses: actions/checkout@v3
-      with:
-        ref: ${{ steps.comment-branch.outputs.head_ref }}
        
     - name: Update baseline
       if: github.event.pull_request.base.ref == 'main'