time vec is no longer passed to step_current #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeldeistler
force-pushed
the
steps
branch
from
409f9ec to
dacf634
Compare
michaeldeistler
force-pushed
the
steps
branch
from
dacf634 to
6e0976b
Compare
michaeldeistler
force-pushed
the
steps
branch
from
5b21e8e to
321553b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API change
Old:
New:
Finally, after this PR, the exact solution will be the same (by a few microvolts). The reason is this: Previously, if i_dur was 2ms, then we stimulated from 1ms to 3ms, whereas the new version stimulates from 1ms to the last time step before 3ms.