Prefix all param and state names with channel name #200
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API changes
FYI @coschroeder @kyralianaka @jnsbck @lappalainenj
HHChannel
is now calledHH
set_params
andset_states
are both calledset
nowget_params
andget_states
does not exist anymore. Use.show()
instead.Rationale for this PR
Questions
Solution
To make this happen, we had to fundamentally change how channels are stored. See #202