Allow renamed channels in simulation #225
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we used
type(channel).__name__
to determine if a channel already exists in the network.However, if we rename a channel, we want to consider the channel a new (different) channel with its own parameter names etc. Therefore, we now use
channel._name
to determine if a channel already exists.The difference is easily visible when doing:
And then inspecting
branch.nodes["HH"]
. Before this commit, this returned:Now, it returns:
@huangziwei FYI