-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI to check if tutorials can be run. #480
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jnsbck
changed the title
Add CI to check of tutorials can be run.
Add CI to check if tutorials can be run.
Nov 4, 2024
jnsbck
force-pushed
the
add_tutorial_ci
branch
from
November 4, 2024 12:58
1a4c4f1
to
345bb4b
Compare
michaeldeistler
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
From my perspective it is fine as it is---always run it once we push to main (which is also when the website is hosted). Feel free to merge!
jnsbck
force-pushed
the
add_tutorial_ci
branch
from
November 14, 2024 18:22
15d91a7
to
b9b1192
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a github action to run all tutorials.
Q: what should the trigger for this be? Not sure if we should run this on every push/pull request.
Might be sufficient if we run this when a PR is marked with
prepare_release
or something.