Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI to check if tutorials can be run. #480

Merged
merged 13 commits into from
Nov 14, 2024
Merged

Add CI to check if tutorials can be run. #480

merged 13 commits into from
Nov 14, 2024

Conversation

jnsbck
Copy link
Contributor

@jnsbck jnsbck commented Nov 4, 2024

This PR adds a github action to run all tutorials.

Q: what should the trigger for this be? Not sure if we should run this on every push/pull request.

Might be sufficient if we run this when a PR is marked with prepare_release or something.

@jnsbck
Copy link
Contributor Author

jnsbck commented Nov 4, 2024

@jnsbck jnsbck changed the title Add CI to check of tutorials can be run. Add CI to check if tutorials can be run. Nov 4, 2024
@jnsbck jnsbck linked an issue Nov 4, 2024 that may be closed by this pull request
Copy link
Contributor

@michaeldeistler michaeldeistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

From my perspective it is fine as it is---always run it once we push to main (which is also when the website is hosted). Feel free to merge!

@jnsbck jnsbck merged commit 175758d into main Nov 14, 2024
1 check passed
@jnsbck jnsbck deleted the add_tutorial_ci branch November 14, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests to check if tutorials run
2 participants