Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Make methods/attributes private #495

Merged
merged 6 commits into from
Nov 14, 2024

Conversation

ntolley
Copy link
Contributor

@ntolley ntolley commented Nov 12, 2024

Closes #448

@michaeldeistler @jnsbck is the list of methods/attributes to make private actually agreed upon? Here's what was stated int he issue:

"par_inds",
"child_inds",
"child_belongs_to_branchpoint",
"solve_indexer",
"cells_list",
"cumsum_nbranchpoints_per_cell",
"cumsum_nbranches"

I've started with par_inds to get a feel for the code base, but I'll wait for you input before continuing

@michaeldeistler
Copy link
Contributor

michaeldeistler commented Nov 13, 2024

Hi Nick! Great that you are getting into Jaxley!

And yes, the list is agreed upon. Thanks for tackling it, let us know if anything is unclear!

Michael

@ntolley ntolley changed the title WIP: Make methods/attributes private [MRG] Make methods/attributes private Nov 14, 2024
@ntolley
Copy link
Contributor Author

ntolley commented Nov 14, 2024

Definitely happy to help out! Super cool project that I think will be great for my research questions

I think I've covered all the attributes so this is ready for review

@michaeldeistler
Copy link
Contributor

Awesome! Automated tests are failing right now because of black. Could you run:

black jaxley
black tests

Thanks a ton!

@jnsbck
Copy link
Contributor

jnsbck commented Nov 14, 2024

Hey! Welcome on board also from my side! :) Cool to have you also working on Jaxley. Feel free to reach out at any time if you have questions or ideas :)

Copy link
Contributor

@michaeldeistler michaeldeistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are passing, and all looks good now! Thanks @ntolley!

@michaeldeistler michaeldeistler merged commit 9aacc4d into jaxleyverse:main Nov 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make some methods / attrs of Module private
3 participants