Rework all tutorials #500
Merged
Rework all tutorials #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnsbck
approved these changes
Nov 14, 2024
| " for batch_ind, batch in enumerate(dataloader):\n", | ||
| " current_batch = batch[0].numpy()\n", |
There was a problem hiding this comment.
Could also be changed to
Comment on lines
+833
to
+834
| " dataloader = Dataset(inputs, labels)\n", | ||
| " dataloader = dataloader.shuffle(seed=epoch).batch(batch_size)\n", |
There was a problem hiding this comment.
Can we change this to
dataset = Dataset(inputs, labels)
for epoch in range(10):
epoch_loss = 0.0
# Our simple dummy dataloader must be shuffled at every epoch.
dataloader = dataset.shuffle(seed=epoch).batch(batch_size)
There was a problem hiding this comment.
alternatively, you can also increment the seed after the last yield or sth. than you would not have to re-init
There was a problem hiding this comment.
The above does not work. I will leave it as it is for now, feel free to change it later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
03_setting_parametersas it had very little content and I want to keep the number of tutorials small. I added its main content into tutorials01_and02_.