Enable param sharing with differently sized groups #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnsbck
force-pushed
the
enable_inhom_param_sharing
branch
from
aea634d to
ab47228
Compare
|
Surprisingly little had to be changed for this to work. I have added a test that checks make_trainable and set behave the same. Lemme know if any other tests are required. |
michaeldeistler
approved these changes
Dec 5, 2024
|
Thanks for adding the clarifying comment :) |
|
fyi @kyralianaka this has been merged now, please let me know if anything does not work as expected! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to enable param sharing for controll groups with different numbers of members. This can be important for sharing params between branches with different numbers of segments or edges with different numbers of pre synaptic cells (see #501).
This also fixes #501.
todos: