Update Regression CI #546
Merged
Update Regression CI #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnsbck
force-pushed
the
update_regression_ci
branch
from
94c00f1 to
eabeb2d
Compare
|
@michaeldeistler could you approve this? This should make the CI pass again. |
michaeldeistler
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since maintaining a baseline is not possible (see #543 for context), I have modified the regression CI to run baselines on main and tests on the PR branch in one go. The trigger for this is now a comment with "/test_regression".
This also makes skipping the regression tests automatic when there is no baseline_file around, rather than having to add
pytest -m "not regression"every time.Reuses a lot of code from before. Works for the moment. Long term we could look at using
asvinstead. (see #543)